https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

matanya <> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |

--- Comment #1 from matanya <> 2012-08-11 23:11:54 UTC ---
did you finish thinking? :P Please push to gerrit if you find it good enough.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)

https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

matanya <> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |

--- Comment #1 from matanya <> 2012-08-11 23:11:54 UTC ---
did you finish thinking? :P Please push to gerrit if you find it good enough.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #2 from Bawolff 2012-08-15 19:56:57 UTC ---
I got sidetracked [I'm a bit of a flitty person and have a tendency of doing
that], but basically I don't really like it - it seems ugly to me - using lang
globals instead of context, and the distinction between parser vs non-parser.
OTOH I'm not sure what a better method would be

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)

https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

matanya <> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |

--- Comment #1 from matanya <> 2012-08-11 23:11:54 UTC ---
did you finish thinking? :P Please push to gerrit if you find it good enough.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #2 from Bawolff 2012-08-15 19:56:57 UTC ---
I got sidetracked [I'm a bit of a flitty person and have a tendency of doing
that], but basically I don't really like it - it seems ugly to me - using lang
globals instead of context, and the distinction between parser vs non-parser.
OTOH I'm not sure what a better method would be

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #3 from Robin Pepermans (SPQRobin) <> 2012-08-15 20:02:03 UTC ---
In which cases it ImageGallery used not in the content? Because, if it's only
on special pages, you can just use the page content language (i.e. parser
language) because that is the same as the user language on special pages.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)

https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

matanya <> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |

--- Comment #1 from matanya <> 2012-08-11 23:11:54 UTC ---
did you finish thinking? :P Please push to gerrit if you find it good enough.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #2 from Bawolff 2012-08-15 19:56:57 UTC ---
I got sidetracked [I'm a bit of a flitty person and have a tendency of doing
that], but basically I don't really like it - it seems ugly to me - using lang
globals instead of context, and the distinction between parser vs non-parser.
OTOH I'm not sure what a better method would be

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #3 from Robin Pepermans (SPQRobin) <> 2012-08-15 20:02:03 UTC ---
In which cases it ImageGallery used not in the content? Because, if it's only
on special pages, you can just use the page content language (i.e. parser
language) because that is the same as the user language on special pages.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #4 from Bawolff 2012-08-16 12:02:10 UTC ---
(In reply to comment #3)
> In which cases it ImageGallery used not in the content? Because, if it's only
> on special pages, you can just use the page content language (i.e. parser
> language) because that is the same as the user language on special pages.

Also category pages at the bottom of the page. (However in that case it is also
not passed a parser object as well.)

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)

https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

matanya <> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |

--- Comment #1 from matanya <> 2012-08-11 23:11:54 UTC ---
did you finish thinking? :P Please push to gerrit if you find it good enough.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #2 from Bawolff 2012-08-15 19:56:57 UTC ---
I got sidetracked [I'm a bit of a flitty person and have a tendency of doing
that], but basically I don't really like it - it seems ugly to me - using lang
globals instead of context, and the distinction between parser vs non-parser.
OTOH I'm not sure what a better method would be

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #3 from Robin Pepermans (SPQRobin) <> 2012-08-15 20:02:03 UTC ---
In which cases it ImageGallery used not in the content? Because, if it's only
on special pages, you can just use the page content language (i.e. parser
language) because that is the same as the user language on special pages.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #4 from Bawolff 2012-08-16 12:02:10 UTC ---
(In reply to comment #3)
> In which cases it ImageGallery used not in the content? Because, if it's only
> on special pages, you can just use the page content language (i.e. parser
> language) because that is the same as the user language on special pages.

Also category pages at the bottom of the page. (However in that case it is also
not passed a parser object as well.)

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #5 from Robin Pepermans (SPQRobin) <> 2012-08-20 18:11:34 UTC ---
(In reply to comment #4)
> Also category pages at the bottom of the page. (However in that case it is also
> not passed a parser object as well.)

So we might just do: if parser object, use parser language; else use the user
language.

(More generally, category pages are a bit troublesome since they are a mix of
content and user language, so the page content language for categories is the
site language by default though a lot of it is in the user language...)

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)

https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

matanya <> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |

--- Comment #1 from matanya <> 2012-08-11 23:11:54 UTC ---
did you finish thinking? :P Please push to gerrit if you find it good enough.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #2 from Bawolff 2012-08-15 19:56:57 UTC ---
I got sidetracked [I'm a bit of a flitty person and have a tendency of doing
that], but basically I don't really like it - it seems ugly to me - using lang
globals instead of context, and the distinction between parser vs non-parser.
OTOH I'm not sure what a better method would be

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #3 from Robin Pepermans (SPQRobin) <> 2012-08-15 20:02:03 UTC ---
In which cases it ImageGallery used not in the content? Because, if it's only
on special pages, you can just use the page content language (i.e. parser
language) because that is the same as the user language on special pages.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #4 from Bawolff 2012-08-16 12:02:10 UTC ---
(In reply to comment #3)
> In which cases it ImageGallery used not in the content? Because, if it's only
> on special pages, you can just use the page content language (i.e. parser
> language) because that is the same as the user language on special pages.

Also category pages at the bottom of the page. (However in that case it is also
not passed a parser object as well.)

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #5 from Robin Pepermans (SPQRobin) <> 2012-08-20 18:11:34 UTC ---
(In reply to comment #4)
> Also category pages at the bottom of the page. (However in that case it is also
> not passed a parser object as well.)

So we might just do: if parser object, use parser language; else use the user
language.

(More generally, category pages are a bit troublesome since they are a mix of
content and user language, so the page content language for categories is the
site language by default though a lot of it is in the user language...)

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

Sumana Harihareswara <> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords|patch, patch-need-review |
CC| |

--- Comment #6 from Sumana Harihareswara <> 2012-08-27 15:18:31 UTC ---
about to mark patch obsolete, removing tags.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)

https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

matanya <> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |

--- Comment #1 from matanya <> 2012-08-11 23:11:54 UTC ---
did you finish thinking? :P Please push to gerrit if you find it good enough.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #2 from Bawolff 2012-08-15 19:56:57 UTC ---
I got sidetracked [I'm a bit of a flitty person and have a tendency of doing
that], but basically I don't really like it - it seems ugly to me - using lang
globals instead of context, and the distinction between parser vs non-parser.
OTOH I'm not sure what a better method would be

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #3 from Robin Pepermans (SPQRobin) <> 2012-08-15 20:02:03 UTC ---
In which cases it ImageGallery used not in the content? Because, if it's only
on special pages, you can just use the page content language (i.e. parser
language) because that is the same as the user language on special pages.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #4 from Bawolff 2012-08-16 12:02:10 UTC ---
(In reply to comment #3)
> In which cases it ImageGallery used not in the content? Because, if it's only
> on special pages, you can just use the page content language (i.e. parser
> language) because that is the same as the user language on special pages.

Also category pages at the bottom of the page. (However in that case it is also
not passed a parser object as well.)

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

--- Comment #5 from Robin Pepermans (SPQRobin) <> 2012-08-20 18:11:34 UTC ---
(In reply to comment #4)
> Also category pages at the bottom of the page. (However in that case it is also
> not passed a parser object as well.)

So we might just do: if parser object, use parser language; else use the user
language.

(More generally, category pages are a bit troublesome since they are a mix of
content and user language, so the page content language for categories is the
site language by default though a lot of it is in the user language...)

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

Sumana Harihareswara <> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords|patch, patch-need-review |
CC| |

--- Comment #6 from Sumana Harihareswara <> 2012-08-27 15:18:31 UTC ---
about to mark patch obsolete, removing tags.

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)
https://bugzilla.wikimedia.org/show_bug.cgi?id=38652

Sumana Harihareswara <> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #10884|0 |1
is obsolete| |

--- Comment #7 from Sumana Harihareswara <> 2012-08-27 15:18:58 UTC ---
Comment on attachment 10884
--> https://bugzilla.wikimedia.org/attachment.cgi?id=10884
ImageGallery use appropriate lang.

Author said "basically I don't really like it".

--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
)