Developers

Popular Threads From Developers:

Adding parsing to Stream

String functions and Print.h

RFC: String in the core?

Aliases of analog pins

Decoupling the compiler from the IDE

List Statistics

Total Threads: 675
Total Posts: 2049

Phrases Used to Find This Thread

Page 1 of 1

04-03-2011 02:47 AM

Developers member admin is online now

User

04-03-2011 02:47 AM

Developers member admin is online now

User

04-03-2011 03:57 AM

Developers member admin is online now

User

Please bear with me as I am not fluent with git-send-email.
Hopefully I have all of this correct.
The following is a series of patches that are almost all trivial
that fix a bunch of compiler warnings.
Most are so trivial that they just have to work, but a one or two
involve casting changes or type changes that could possibly have
edge conditions - but then the code they fix almost certainly did
too.
None are tested beyond "Works for me on my current project"
[PATCH 01/13] /dhl/ fix compiler waring
[PATCH 02/13] /dhl/ casts to fix compiler warnings
[PATCH 03/13] /dhl/ fix compiler warning
[PATCH 04/13] /dhl/ fix compiler warning
[PATCH 05/13] /dhl/ fix compiler warnings
[PATCH 06/13] /dhl/ fix compiler warnings
[PATCH 07/13] /dhl/ fix compiler warnings
[PATCH 08/13] /dhl/ fix compiler warnings
[PATCH 09/13] /dhli/ fix compiler warnings
[PATCH 10/13] /dhl/ fix compiler warnings
[PATCH 11/13] /dhl/ fix compiler warnings
[PATCH 12/13] /dhl/ fix compiler warnings
[PATCH 13/13] /dhl/ fix compiler warnings

_______________________________________________
Developers mailing list

http://arduino.cc/mailman/listinfo/developers_arduino.cc
)
---
hardware/arduino/cores/arduino/pins_arduino.c | 84 ++++++++++++------------
1 files changed, 42 insertions(+), 42 deletions(-)

diff --git a/hardware/arduino/cores/arduino/pins_arduino.c b/hardware/arduino/cores/arduino/pins_arduino.c
index 0c816e9..62e10ad 100755
--- a/hardware/arduino/cores/arduino/pins_arduino.c
+++ b/hardware/arduino/cores/arduino/pins_arduino.c
@@ -81,50 +81,50 @@
#if defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__)
const uint16_t PROGMEM port_to_mode_PGM[] = {
NOT_A_PORT,
- &DDRA,
- &DDRB,
- &DDRC,
- &DDRD,
- &DDRE,
- &DDRF,
- &DDRG,
- &DDRH,
+ (uint16_t) &DDRA,
+ (uint16_t) &DDRB,
+ (uint16_t) &DDRC,
+ (uint16_t) &DDRD,
+ (uint16_t) &DDRE,
+ (uint16_t) &DDRF,
+ (uint16_t) &DDRG,
+ (uint16_t) &DDRH,
NOT_A_PORT,
- &DDRJ,
- &DDRK,
- &DDRL,
+ (uint16_t) &DDRJ,
+ (uint16_t) &DDRK,
+ (uint16_t) &DDRL,
};

const uint16_t PROGMEM port_to_output_PGM[] = {
NOT_A_PORT,
- &PORTA,
- &PORTB,
- &PORTC,
- &PORTD,
- &PORTE,
- &PORTF,
- &PORTG,
- &PORTH,
+ (uint16_t) &PORTA,
+ (uint16_t) &PORTB,
+ (uint16_t) &PORTC,
+ (uint16_t) &PORTD,
+ (uint16_t) &PORTE,
+ (uint16_t) &PORTF,
+ (uint16_t) &PORTG,
+ (uint16_t) &PORTH,
NOT_A_PORT,
- &PORTJ,
- &PORTK,
- &PORTL,
+ (uint16_t) &PORTJ,
+ (uint16_t) &PORTK,
+ (uint16_t) &PORTL,
};

const uint16_t PROGMEM port_to_input_PGM[] = {
NOT_A_PIN,
- &PINA,
- &PINB,
- &PINC,
- &PIND,
- &PINE,
- &PINF,
- &PING,
- &PINH,
+ (uint16_t) &PINA,
+ (uint16_t) &PINB,
+ (uint16_t) &PINC,
+ (uint16_t) &PIND,
+ (uint16_t) &PINE,
+ (uint16_t) &PINF,
+ (uint16_t) &PING,
+ (uint16_t) &PINH,
NOT_A_PIN,
- &PINJ,
- &PINK,
- &PINL,
+ (uint16_t) &PINJ,
+ (uint16_t) &PINK,
+ (uint16_t) &PINL,
};

const uint8_t PROGMEM digital_pin_to_port_PGM[] = {
@@ -358,25 +358,25 @@ const uint8_t PROGMEM digital_pin_to_timer_PGM[] = {
const uint16_t PROGMEM port_to_mode_PGM[] = {
NOT_A_PORT,
NOT_A_PORT,
- &DDRB,
- &DDRC,
- &DDRD,
+ (uint16_t) &DDRB,
+ (uint16_t) &DDRC,
+ (uint16_t) &DDRD,
};

const uint16_t PROGMEM port_to_output_PGM[] = {
NOT_A_PORT,
NOT_A_PORT,
- &PORTB,
- &PORTC,
- &PORTD,
+ (uint16_t) &PORTB,
+ (uint16_t) &PORTC,
+ (uint16_t) &PORTD,
};

const uint16_t PROGMEM port_to_input_PGM[] = {
NOT_A_PORT,
NOT_A_PORT,
- &PINB,
- &PINC,
- &PIND,
+ (uint16_t) &PINB,
+ (uint16_t) &PINC,
+ (uint16_t) &PIND,
};

const uint8_t PROGMEM digital_pin_to_port_PGM[] = {
--
1.7.1

_______________________________________________
Developers mailing list

http://arduino.cc/mailman/listinfo/developers_arduino.cc
)
Hi,

I applied these until I ran out of steam:
https://github.com/arduino/Arduino/commit/d59fcb8eed1d06c21309cb36c6906867a9a15124

You should probably post the rest to the Google Code issue list so
they don't get lost: http://code.google.com/p/arduino/issues/list

David

On Thu, Mar 3, 2011 at 9:47 PM, David H. Lynch Jr <> wrote:
> Please bear with me as I am not fluent with git-send-email.
> Hopefully I have all of this correct.
> The following is a series of patches that are almost all trivial
> that fix a bunch of compiler warnings.
> Most are so trivial that they just have to work, but a one or two
> involve casting changes or type changes that could possibly have
> edge conditions - but then the code they fix almost certainly did
> too.
> None are tested beyond "Works for me on my current project"
> [PATCH 01/13] /dhl/ fix compiler waring
> [PATCH 02/13] /dhl/ casts to fix compiler warnings
> [PATCH 03/13] /dhl/ fix compiler warning
> [PATCH 04/13] /dhl/ fix compiler warning
> [PATCH 05/13] /dhl/ fix compiler warnings
> [PATCH 06/13] /dhl/ fix compiler warnings
> [PATCH 07/13] /dhl/ fix compiler warnings
> [PATCH 08/13] /dhl/ fix compiler warnings
> [PATCH 09/13] /dhli/ fix compiler warnings
> [PATCH 10/13] /dhl/ fix compiler warnings
> [PATCH 11/13] /dhl/ fix compiler warnings
> [PATCH 12/13] /dhl/ fix compiler warnings
> [PATCH 13/13] /dhl/ fix compiler warnings
>
> _______________________________________________
> Developers mailing list
>
> http://arduino.cc/mailman/listinfo/developers_arduino.cc
>

_______________________________________________
Developers mailing list

http://arduino.cc/mailman/listinfo/developers_arduino.cc
)

Page 1 of 1

NewsArc Lists | Culture Pages | Computing Archive | Media-Pages

Link to this page on your blog or website by copying the HTML code below and pasting it into your site:

Next Thread »