Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

)

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

)

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

)

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
)

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

)

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
)

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
)

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, Apr 23, 2010 at 05:17:54AM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 4b1dab5... s3-winbind: fix setup_domain_child() callers.
> from ca0e5ea... s4-smbtorture: use server_name for all printerdriver delete and enum operations.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, Apr 23, 2010 at 05:17:54AM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 4b1dab5... s3-winbind: fix setup_domain_child() callers.
> from ca0e5ea... s4-smbtorture: use server_name for all printerdriver delete and enum operations.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Thursday 06 May 2010 23:14:08 you wrote:
> On Thu, 2010-05-06 at 11:14 -0500, Andreas Schneider wrote:
> > The branch, master has been updated
> >
> > via 8290007... talloc: Documented the missing string functions.
> >
> > from 516f7c5... Fix SMB2 lock tests up to cancel-by-close.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, Apr 23, 2010 at 05:17:54AM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 4b1dab5... s3-winbind: fix setup_domain_child() callers.
> from ca0e5ea... s4-smbtorture: use server_name for all printerdriver delete and enum operations.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Thursday 06 May 2010 23:14:08 you wrote:
> On Thu, 2010-05-06 at 11:14 -0500, Andreas Schneider wrote:
> > The branch, master has been updated
> >
> > via 8290007... talloc: Documented the missing string functions.
> >
> > from 516f7c5... Fix SMB2 lock tests up to cancel-by-close.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. > idl: get the logic of the prevous commit right

thanks!
)

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, Apr 23, 2010 at 05:17:54AM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 4b1dab5... s3-winbind: fix setup_domain_child() callers.
> from ca0e5ea... s4-smbtorture: use server_name for all printerdriver delete and enum operations.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Thursday 06 May 2010 23:14:08 you wrote:
> On Thu, 2010-05-06 at 11:14 -0500, Andreas Schneider wrote:
> > The branch, master has been updated
> >
> > via 8290007... talloc: Documented the missing string functions.
> >
> > from 516f7c5... Fix SMB2 lock tests up to cancel-by-close.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. > idl: get the logic of the prevous commit right

thanks!
) Jelmer,

this is needed since we don't have implemented the functional level
change trigger yet (which would also adjust the second value after the
first change).
The tool should support both the actual unchecked s4 behaviour and the
Windows one - therefore this strange-looking exception handling.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> hOn Fri, 2010-05-14 at 12:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via d712356... s4:repl_meta_data LDB module - fix counter types
>> via 8608eae... s4:net domainlevel tool - fix up the error handling as Jelmer suggested
>> via 6d95a20... s4:dsdb_cache LDB module - fix a typo
>> via da5cd4b... s4:samldb LDB module - remove unused variables
>> from b5dc394... s4:gensec expose gensec_set_target_principal for use outside GENSEC
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, Apr 23, 2010 at 05:17:54AM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 4b1dab5... s3-winbind: fix setup_domain_child() callers.
> from ca0e5ea... s4-smbtorture: use server_name for all printerdriver delete and enum operations.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Thursday 06 May 2010 23:14:08 you wrote:
> On Thu, 2010-05-06 at 11:14 -0500, Andreas Schneider wrote:
> > The branch, master has been updated
> >
> > via 8290007... talloc: Documented the missing string functions.
> >
> > from 516f7c5... Fix SMB2 lock tests up to cancel-by-close.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. > idl: get the logic of the prevous commit right

thanks!
) Jelmer,

this is needed since we don't have implemented the functional level
change trigger yet (which would also adjust the second value after the
first change).
The tool should support both the actual unchecked s4 behaviour and the
Windows one - therefore this strange-looking exception handling.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> hOn Fri, 2010-05-14 at 12:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via d712356... s4:repl_meta_data LDB module - fix counter types
>> via 8608eae... s4:net domainlevel tool - fix up the error handling as Jelmer suggested
>> via 6d95a20... s4:dsdb_cache LDB module - fix a typo
>> via da5cd4b... s4:samldb LDB module - remove unused variables
>> from b5dc394... s4:gensec expose gensec_set_target_principal for use outside GENSEC
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Wed, May 19, 2010 at 04:17:00PM +0200, Guenther Deschner wrote:
> On Tue, May 18, 2010 at 06:42:07PM -0500, Jeremy Allison wrote:
> > The branch, master has been updated
> > via 6a90307... Fix our NTLMSSP implementation against the Microsoft torture tester.
> > from 829c876... Change data_blob() to be based on top of data_blob_talloc(), instead of the reverse (as it is now).
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, Apr 23, 2010 at 05:17:54AM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 4b1dab5... s3-winbind: fix setup_domain_child() callers.
> from ca0e5ea... s4-smbtorture: use server_name for all printerdriver delete and enum operations.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Thursday 06 May 2010 23:14:08 you wrote:
> On Thu, 2010-05-06 at 11:14 -0500, Andreas Schneider wrote:
> > The branch, master has been updated
> >
> > via 8290007... talloc: Documented the missing string functions.
> >
> > from 516f7c5... Fix SMB2 lock tests up to cancel-by-close.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. > idl: get the logic of the prevous commit right

thanks!
) Jelmer,

this is needed since we don't have implemented the functional level
change trigger yet (which would also adjust the second value after the
first change).
The tool should support both the actual unchecked s4 behaviour and the
Windows one - therefore this strange-looking exception handling.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> hOn Fri, 2010-05-14 at 12:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via d712356... s4:repl_meta_data LDB module - fix counter types
>> via 8608eae... s4:net domainlevel tool - fix up the error handling as Jelmer suggested
>> via 6d95a20... s4:dsdb_cache LDB module - fix a typo
>> via da5cd4b... s4:samldb LDB module - remove unused variables
>> from b5dc394... s4:gensec expose gensec_set_target_principal for use outside GENSEC
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Wed, May 19, 2010 at 04:17:00PM +0200, Guenther Deschner wrote:
> On Tue, May 18, 2010 at 06:42:07PM -0500, Jeremy Allison wrote:
> > The branch, master has been updated
> > via 6a90307... Fix our NTLMSSP implementation against the Microsoft torture tester.
> > from 829c876... Change data_blob() to be based on top of data_blob_talloc(), instead of the reverse (as it is now).
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Am 21.05.2010 21:09, schrieb Jeremy Allison:
> The branch, master has been updated
> via efb2922... Make krb5 over SMB2 identical to the way we handle it in SMB1.
> from f576cc5... Doh! If you're going to give advice in "useage", make sure it's correct.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, Apr 23, 2010 at 05:17:54AM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 4b1dab5... s3-winbind: fix setup_domain_child() callers.
> from ca0e5ea... s4-smbtorture: use server_name for all printerdriver delete and enum operations.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Thursday 06 May 2010 23:14:08 you wrote:
> On Thu, 2010-05-06 at 11:14 -0500, Andreas Schneider wrote:
> > The branch, master has been updated
> >
> > via 8290007... talloc: Documented the missing string functions.
> >
> > from 516f7c5... Fix SMB2 lock tests up to cancel-by-close.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. > idl: get the logic of the prevous commit right

thanks!
) Jelmer,

this is needed since we don't have implemented the functional level
change trigger yet (which would also adjust the second value after the
first change).
The tool should support both the actual unchecked s4 behaviour and the
Windows one - therefore this strange-looking exception handling.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> hOn Fri, 2010-05-14 at 12:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via d712356... s4:repl_meta_data LDB module - fix counter types
>> via 8608eae... s4:net domainlevel tool - fix up the error handling as Jelmer suggested
>> via 6d95a20... s4:dsdb_cache LDB module - fix a typo
>> via da5cd4b... s4:samldb LDB module - remove unused variables
>> from b5dc394... s4:gensec expose gensec_set_target_principal for use outside GENSEC
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Wed, May 19, 2010 at 04:17:00PM +0200, Guenther Deschner wrote:
> On Tue, May 18, 2010 at 06:42:07PM -0500, Jeremy Allison wrote:
> > The branch, master has been updated
> > via 6a90307... Fix our NTLMSSP implementation against the Microsoft torture tester.
> > from 829c876... Change data_blob() to be based on top of data_blob_talloc(), instead of the reverse (as it is now).
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Am 21.05.2010 21:09, schrieb Jeremy Allison:
> The branch, master has been updated
> via efb2922... Make krb5 over SMB2 identical to the way we handle it in SMB1.
> from f576cc5... Doh! If you're going to give advice in "useage", make sure it's correct.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, May 21, 2010 at 09:13:38PM +0200, Stefan (metze) Metzmacher wrote:
> Am 21.05.2010 21:09, schrieb Jeremy Allison:
> > The branch, master has been updated
> > via efb2922... Make krb5 over SMB2 identical to the way we handle it in SMB1.
> > from f576cc5... Doh! If you're going to give advice in "useage", make sure it's correct.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe.

Okay, okay - will remove them again.

But I have to state that each torture output call seems to have a
different policy regarding newlines at the end or not:

e.g. torture_comment(tctx, "Test sec_desc level\n") - here it's needed.

Is there an easy rule when yes, when no? It would be nice to see only
one method to don't have to worry about this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sun, 2010-04-11 at 04:34 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via c7dfe73... s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
>> from 52ab3ca... s4:torture - "dbspeed" test
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Hi Jelmer!

I wrote this patch using instructions by abartlet. He might has overseen
this.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Fri, 2010-04-09 at 16:52 -0500, Matthias Dieter Wallnöfer wrote:
>
>> Summary of changes:
>> source4/selftest/tests.sh | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>>
>> Changeset truncated at 500 lines:
>>
>> diff --git a/source4/selftest/tests.sh b/source4/selftest/tests.sh
>> index 1fd9d38..d4f7e47 100755
>> --- a/source4/selftest/tests.sh
>> +++ b/source4/selftest/tests.sh
>> @@ -126,7 +126,9 @@ if grep ENABLE_GNUTLS.1 $CONFIG_H> /dev/null; then
>> plantestsuite "ldb.ldaps with options $options" dc $bbdir/test_ldb.sh ldaps \$SERVER_IP $options
>> done
>> fi
>> -plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +for options in "" "-U\$USERNAME%\$PASSWORD"; do
>> + plantestsuite "ldb.ldapi with options $options" dc $bbdir/test_ldb.sh ldapi \$PREFIX_ABS/dc/private/ldapi $options
>> +done
>>
> I'm not too familiar with this code, but I'm wondering - does running
> the ldapi test with -U make sense, don't we just use the socket
> permissions?
>
> Cheers,
>
> Jelmer
>

) On Wed, 2010-04-14 at 23:39 +1000, wrote:
> > Author: Andrew Tridgell <>
> > Date: Wed Apr 14 23:38:05 2010 +1000
> >
> > Merge branch 'master' of ssh://git.samba.org/data/git/samba
>
> sorry, I forgot a --rebase on a git pull

Would it make sense to have a hook that prevents pushes of merge
commits ?
Or do we have legitimate uses for merges in the main branch ?

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) Hi Matthias,

On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Sorry Jelmer,

this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
issue is the fact that we have already approximately 150-200 occourences
of it under "source4" (checked with "cscope"). And we merge more and
more with the s3 codebase so we get more and more occourences. Therefore
I would simply propose to allow it for s4 as well.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> On Sat, 2010-04-17 at 13:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> Matthias Dieter Wallnöfer schrieb:
> > Sorry Jelmer,
> >
> > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > issue is the fact that we have already approximately 150-200 occourences
> > of it under "source4" (checked with "cscope"). And we merge more and
> > more with the s3 codebase so we get more and more occourences. Therefore
> > I would simply propose to allow it for s4 as well.
>
> I think it's fine to use it also in source4.

Looks fine to me too, trading a warning from valgrind with a segfault
for dereferencing a NULL pointer doesn't seem a big issue.
Actually a segfault has probably more chances to be dealt with earlier.

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > Matthias Dieter Wallnöfer schrieb:
> > > Sorry Jelmer,
> > >
> > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > issue is the fact that we have already approximately 150-200 occourences
> > > of it under "source4" (checked with "cscope"). And we merge more and
> > > more with the s3 codebase so we get more and more occourences. Therefore
> > > I would simply propose to allow it for s4 as well.
> >
> > I think it's fine to use it also in source4.
>
> Looks fine to me too, trading a warning from valgrind with a segfault
> for dereferencing a NULL pointer doesn't seem a big issue.
> Actually a segfault has probably more chances to be dealt with earlier.
It would be nice to standardize on one or the other though rather than
using a strange mix of both. Should we encourage the use of
TALLOC_FREE() over talloc_free() ?

Cheers,

Jelmer
) Hi Tridge,

On Tue, 2010-04-20 at 01:11 -0500, Andrew Tridgell wrote:
> The branch, master has been updated
> via f1c5239... pytalloc: ensure talloc_ctx is directly after PyObject_HEAD
> via 45be1c7... talloc: there is no ambiguity when freeing a ptr with a null parent
> via 773a8af... tdb: update tdb ABI to use hide_symbols=True
> via cdaac0a... build: include uninitialised data in the ABI symbols
> via 0e56037... build: quote cross-answer strings
> via f2bd78c... build: allow "waf --abi-check" to force a re-check of the ABI
> from 538a07a... s4:provisionbackend Print the command we failed to start slapd with
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Tue, 2010-04-20 at 12:36 +0100, Jelmer Vernooij wrote:
> On Mon, 2010-04-19 at 12:26 -0400, simo wrote:
> > On Mon, 2010-04-19 at 18:17 +0200, Stefan (metze) Metzmacher wrote:
> > > Matthias Dieter Wallnöfer schrieb:
> > > > Sorry Jelmer,
> > > >
> > > > this wasn't clear (to prevent the use of "TALLOC_FREE"). But a real
> > > > issue is the fact that we have already approximately 150-200 occourences
> > > > of it under "source4" (checked with "cscope"). And we merge more and
> > > > more with the s3 codebase so we get more and more occourences. Therefore
> > > > I would simply propose to allow it for s4 as well.
> > >
> > > I think it's fine to use it also in source4.
> >
> > Looks fine to me too, trading a warning from valgrind with a segfault
> > for dereferencing a NULL pointer doesn't seem a big issue.
> > Actually a segfault has probably more chances to be dealt with earlier.
> It would be nice to standardize on one or the other though rather than
> using a strange mix of both. Should we encourage the use of
> TALLOC_FREE() over talloc_free() ?

In my projects I actually use talloc_zfree(), which is similar to
TALLOC_FREE() but less ugly to see :)

given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
want to adopt the same guideline in s4

Simo.

--
Simo Sorce
Samba Team GPL Compliance Officer <>
Principal Software Engineer at Red Hat, Inc. <>

) On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
>
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
>
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker
) Hi Volker,

> Given a recent bug I had to fix because I was not aware
> SSVAL is a macro (I used val++ in the argument), I have to
> agree with Jeremy that macros should be as ugly to read as
> possible.

that only applies when the macro uses one of its arguments more than
once.

Lot's of normal C library calls are in fact macros on some
platforms. glibc uses them a lot.

Cheers, Tridge
) On Thu, Apr 22, 2010 at 07:36:27PM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 413ffe9... s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths.
> from f6bdfd9... s4-smbtorture: test both 32bit and 64bit driver uploads in RPC-SPOOLSS-DRIVER.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, Apr 23, 2010 at 05:17:54AM -0500, Günther Deschner wrote:
> The branch, master has been updated
> via 4b1dab5... s3-winbind: fix setup_domain_child() callers.
> from ca0e5ea... s4-smbtorture: use server_name for all printerdriver delete and enum operations.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Thursday 06 May 2010 23:14:08 you wrote:
> On Thu, 2010-05-06 at 11:14 -0500, Andreas Schneider wrote:
> > The branch, master has been updated
> >
> > via 8290007... talloc: Documented the missing string functions.
> >
> > from 516f7c5... Fix SMB2 lock tests up to cancel-by-close.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. > idl: get the logic of the prevous commit right

thanks!
) Jelmer,

this is needed since we don't have implemented the functional level
change trigger yet (which would also adjust the second value after the
first change).
The tool should support both the actual unchecked s4 behaviour and the
Windows one - therefore this strange-looking exception handling.

Greets,
Matthias

Jelmer Vernooij wrote:
> Hi Matthias,
>
> hOn Fri, 2010-05-14 at 12:12 -0500, Matthias Dieter Wallnöfer wrote:
>
>> The branch, master has been updated
>> via d712356... s4:repl_meta_data LDB module - fix counter types
>> via 8608eae... s4:net domainlevel tool - fix up the error handling as Jelmer suggested
>> via 6d95a20... s4:dsdb_cache LDB module - fix a typo
>> via da5cd4b... s4:samldb LDB module - remove unused variables
>> from b5dc394... s4:gensec expose gensec_set_target_principal for use outside GENSEC
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Wed, May 19, 2010 at 04:17:00PM +0200, Guenther Deschner wrote:
> On Tue, May 18, 2010 at 06:42:07PM -0500, Jeremy Allison wrote:
> > The branch, master has been updated
> > via 6a90307... Fix our NTLMSSP implementation against the Microsoft torture tester.
> > from 829c876... Change data_blob() to be based on top of data_blob_talloc(), instead of the reverse (as it is now).
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. Am 21.05.2010 21:09, schrieb Jeremy Allison:
> The branch, master has been updated
> via efb2922... Make krb5 over SMB2 identical to the way we handle it in SMB1.
> from f576cc5... Doh! If you're going to give advice in "useage", make sure it's correct.
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On Fri, May 21, 2010 at 09:13:38PM +0200, Stefan (metze) Metzmacher wrote:
> Am 21.05.2010 21:09, schrieb Jeremy Allison:
> > The branch, master has been updated
> > via efb2922... Make krb5 over SMB2 identical to the way we handle it in SMB1.
> > from f576cc5... Doh! If you're going to give advice in "useage", make sure it's correct.
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
___________________________________________________

Posted on the Samba-technical mailing list. Go to https://lists.samba.org/mailman/listinfo/samba-technical to subscribe. On 2010-05-25 at 07:41 +0200 Stefan (metze) Metzmacher sent off:
> I think we also need -qhalt=e here, to match -Werror.
>
> I'm wondering if --errwarn is the correct thing for the sun case...

-qhalt=w and -errwarn=%all are the equivalent options for -Werror. Some
configure checks need to bail out errors even on warnings, that's all what
this is needed for.

Cheers
Björn
)